diff --git a/.gitignore b/.gitignore index 28531ab..2e69eff 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ -.codex/ +.codex +.claude \ No newline at end of file diff --git a/README.md b/README.md index 46926b3..1162cda 100644 --- a/README.md +++ b/README.md @@ -153,6 +153,17 @@ The skill uses XML-structured prompts inspired by adversarial review methodology See [examples/review-output.md](examples/review-output.md) for a sample adversarial review output. +## Known limitations + +- **Plan Mode and `/tmp` writes.** In Claude Code Plan Mode, writing review + prompts to `/tmp` may trigger a permission prompt or cause Plan Mode to exit. + This does not affect review correctness — the review mode is already determined, + and only the plan file and temp files are modified. +- **`resume` inherits sandbox.** The `codex exec resume` command does not accept + `-s` (sandbox) — sandbox is inherited from the original session. The first + `codex exec` call sets the sandbox to `read-only`, and all subsequent resume + rounds use the same setting. + ## Roadmap - [ ] Gemini as alternative reviewer backend diff --git a/SKILL.md b/SKILL.md index 7cf89bf..7b8e7c7 100644 --- a/SKILL.md +++ b/SKILL.md @@ -16,7 +16,7 @@ Sends current work for adversarial review through an external AI model (OpenAI C - `/adversarial-review plan` — force plan review - `/adversarial-review code` — force code review - `/adversarial-review ` — review a specific file (argument contains `/` or `.`) -- Override reasoning: `/adversarial-review xhigh` or `/adversarial-review low` (one of: `none`, `low`, `medium`, `high`, `xhigh`) +- Override reasoning: `/adversarial-review xhigh` or `/adversarial-review medium` (one of: `medium`, `high`, `xhigh`) - Override model: `/adversarial-review model:gpt-5.3-codex` (argument with `model:` prefix) ## Instructions @@ -295,6 +295,8 @@ Flags: **Prompt delivery:** write the prompt to `/tmp/codex-prompt-${REVIEW_ID}.md` via **Write tool**, then pass via stdin redirection (`- < file`). This avoids shell quoting issues with long XML prompts. +**Plan Mode note:** Writing to `/tmp` via Write tool may trigger a permission prompt or exit Plan Mode. This is a known Claude Code limitation — Plan Mode restricts edits to the plan file only. If this happens, it does not affect review correctness: the review mode is already determined, and the skill only edits the plan file and `/tmp` temp files. + ```bash timeout 600 codex exec \ -m gpt-5.4 \ @@ -391,6 +393,8 @@ timeout 600 codex exec resume ${CODEX_SESSION_ID} \ Use `timeout: 620000` in Bash tool parameters. +**Note:** `resume` does not accept `-s` (sandbox) — sandbox is inherited from the original session. Do not pass `-s` to resume. The `-m` (model) flag is accepted if you need to override the model. + stderr is redirected to temp file for diagnostics. On resume failure, check `/tmp/codex-stderr-${REVIEW_ID}.txt` for details. 3. Check the result by exit code: