From 097808d158855905927db37bb6da87c79bcb3fcc Mon Sep 17 00:00:00 2001 From: Dmitrii Date: Thu, 16 Apr 2026 13:24:34 +0300 Subject: [PATCH] =?UTF-8?q?fix(skill):=20=D0=B4=D0=B5=D1=82=D0=B5=D0=BA?= =?UTF-8?q?=D1=86=D0=B8=D1=8F=20=D0=BC=D1=91=D1=80=D1=82=D0=B2=D0=BE=D0=B3?= =?UTF-8?q?=D0=BE=20=D1=82=D0=B8=D0=BC=D0=BC=D0=B5=D0=B9=D1=82=D0=B0,=20in?= =?UTF-8?q?line=20plan=20artifact,=20NOT=20VERIFIED=20state?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Закрывает три failure mode SendMessage: tool нет, ошибка, routing ack без контента (тиммейт завершился, inbox мёртв). Лид теперь обнаруживает проблему сам, не ждёт репорта от юзера. Для plan mode с inline планами: полный текст ревизированного плана передаётся inline (и в same-teammate, и в re-spawn), не через temp file — Write tool недоступен в Plan Mode. Re-spawn briefing стал mode-aware. Step 6 получил явное NOT VERIFIED терминальное состояние с WARNING. Co-Authored-By: Claude Opus 4.6 (1M context) --- SKILL.md | 75 ++++++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 56 insertions(+), 19 deletions(-) diff --git a/SKILL.md b/SKILL.md index 0f674cc..0600a49 100644 --- a/SKILL.md +++ b/SKILL.md @@ -170,7 +170,22 @@ Before sending, check that the teammate is still reachable: - If the tool is missing or the call returns an error — the teammate is no longer active, skip to the fallback below -If the teammate is reachable, send a message with the list of fixes: +After sending, check what SendMessage actually returned: +- **Reviewer's response** (review content, findings, VERDICT) — the + teammate is alive. Proceed to Step 3. +- **Routing acknowledgment only** (e.g. `{"success": true, "message": + "Message sent to reviewer's inbox"}` without review content) — the + teammate's process has ended. The message was delivered to a dead + inbox. Do not wait for a response — proceed to the fallback below + immediately. + +If the teammate is reachable, send a message with the list of fixes. + +**For plan mode with inline plans:** the reviewer already has the +original plan in context, but a fix summary alone is not enough — +include the full text of the current revised plan in your message +so the reviewer verifies the actual artifact. This works in Plan Mode +(SendMessage is communication, not file writing). ``` I've revised based on your feedback. @@ -178,6 +193,10 @@ I've revised based on your feedback. Here's what I changed: [List of fixes from Step 4] +[For plan mode with inline plans only — include full revised plan text:] +## Current revised plan +[Full text of the revised plan] + Re-review with the same adversarial stance. Focus on: 1. Whether my fixes actually resolve the reported issues 2. Any NEW issues introduced by the fixes @@ -189,8 +208,10 @@ If the reviewer responds — return to **Step 3**. **If the reviewer does not respond** (teammate is no longer active): -1. **Operator available** (interactive session — the conversation was - initiated by a human message, not a CI trigger or scheduled run) — ask: +1. **Operator available** (interactive session — you received a direct + human message earlier in this conversation, not just an automated + trigger or scheduled run; when in doubt, default to presenting + options) — ask: ``` The reviewer is no longer active. Fixes have been applied: [List of fixes from Step 4] @@ -199,9 +220,18 @@ If the reviewer responds — return to **Step 3**. (a) Spawn a new reviewer to verify fixes (expensive — full project re-read) (b) Conclude the review — fixes applied, verification is on you ``` - If the operator chooses (a) — spawn a new reviewer with this briefing: + If the operator chooses (a) — spawn a new reviewer. Use the same + mode-appropriate briefing from **Step 2** (plan, code, or code-vs-plan), + and append the previous findings and fixes sections. + + **For plan mode with inline plans:** include the full text of the + current revised plan in the briefing (same approach as Step 2 for + initial inline plans). The new reviewer has no prior context — it + must see the actual artifact, not just a fix summary. + ``` - You are reviewing code changes in this repository. + [Mode-appropriate briefing from Step 2; for inline plans — include + the full revised plan text, not the original] This is a re-review (Round N). A previous reviewer found issues that have been addressed. @@ -217,22 +247,11 @@ If the reviewer responds — return to **Step 3**. End with VERDICT: APPROVED or VERDICT: REVISE. ``` Continue from Step 3. - If the operator chooses (b) — proceed to Step 6. + If the operator chooses (b) — proceed to Step 6, use the + **"Not re-verified"** terminal state. 2. **Operator not available** (headless, CI, scheduled run) — proceed - to Step 6 with status "fixes applied, not re-verified": - ``` - ## Team Review — Summary (mode: ) - - **Status:** Fixes applied, re-verification not completed - (reviewer became inactive after Round N) - - **Applied fixes:** - [List of fixes per finding] - - **Note:** First-round findings were addressed but not re-verified - by the reviewer. Manual review of fixes is recommended. - ``` + to Step 6, use the **"Not re-verified"** terminal state. ### Step 6: Final result @@ -248,6 +267,24 @@ If the reviewer responds — return to **Step 3**. **Reviewed and approved by the reviewer teammate. Awaiting your decision.** ``` +**Not re-verified** (reviewer became inactive, operator chose to conclude +or headless mode): +``` +## Team Review — Summary (mode: ) + +**Status:** NOT VERIFIED — fixes applied, reviewer did not re-verify + +**Round N findings:** +[Verbatim findings from the last reviewer round] + +**Applied fixes:** +[List of fixes per finding] + +--- +**WARNING: This is NOT an approval. Fixes were applied but never verified +by the reviewer. Manual review of the fixes is required before merging.** +``` + **Maximum rounds reached:** ``` ## Team Review — Summary (mode: )