fix(skill): устойчивость multi-round ревью при нестабильном Agent Teams
SendMessage для тиммейтов Agent Teams работает нестабильно: может быть недоступен как инструмент или создавать нового агента без контекста. Step 5 теперь проверяет доступность тиммейта перед отправкой. Если тиммейт неактивен — спрашивает оператора (interactive) или завершает со статусом "fixes applied, not re-verified" (headless). Re-spawn доступен как опция, не как дефолт. Также: multi-round секция в adversarial-reviewer.md, исправленные пути установки в README, убраны ложные утверждения о statefulness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -3,19 +3,19 @@ name: claude-team-review
|
||||
description: >
|
||||
Adversarial code/plan review using Claude Code Agent Teams. Spawns
|
||||
a reviewer teammate that reads the project, runs tests, checks docs,
|
||||
and delivers findings. Lead fixes issues, teammate re-reviews — stateful,
|
||||
no context loss between rounds. Use when user says /claude-team-review,
|
||||
asks for team review, team-based code review, or wants a stateful
|
||||
adversarial review without external dependencies.
|
||||
and delivers findings. Lead fixes issues and requests re-review from
|
||||
the same teammate. Use when user says /claude-team-review, asks for
|
||||
team review, team-based code review, or wants an adversarial review
|
||||
without external dependencies.
|
||||
user_invocable: true
|
||||
---
|
||||
|
||||
# Claude Team Review
|
||||
|
||||
Spawns an adversarial reviewer **teammate** (Agent Teams) to review plans
|
||||
or code. The reviewer keeps its context across rounds — no re-reading the
|
||||
project on every iteration. The lead fixes issues; the reviewer re-checks.
|
||||
Maximum 5 rounds.
|
||||
or code. The lead fixes issues and requests re-review from the same
|
||||
teammate. If the teammate is no longer active, the lead decides how
|
||||
to proceed based on context. Maximum 5 rounds.
|
||||
|
||||
> **Requires:** Claude Code ≥ 2.1.32, experimental Agent Teams enabled
|
||||
> (`CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1` in settings or environment).
|
||||
@@ -165,7 +165,12 @@ this for the user.
|
||||
|
||||
### Step 5: Request re-review (Rounds 2–5)
|
||||
|
||||
Send a message to the **same reviewer teammate** (context is preserved):
|
||||
Before sending, check that the teammate is still reachable:
|
||||
- Verify that SendMessage is available as a tool
|
||||
- If the tool is missing or the call returns an error — the teammate
|
||||
is no longer active, skip to the fallback below
|
||||
|
||||
If the teammate is reachable, send a message with the list of fixes:
|
||||
|
||||
```
|
||||
I've revised based on your feedback.
|
||||
@@ -180,11 +185,54 @@ Re-review with the same adversarial stance. Focus on:
|
||||
End with VERDICT: APPROVED or VERDICT: REVISE.
|
||||
```
|
||||
|
||||
The reviewer still has the full context from the previous round — it
|
||||
already knows the project structure, the plan, the original findings.
|
||||
It only needs to verify the fixes and check for new issues.
|
||||
If the reviewer responds — return to **Step 3**.
|
||||
|
||||
Return to **Step 3**.
|
||||
**If the reviewer does not respond** (teammate is no longer active):
|
||||
|
||||
1. **Operator available** (interactive session — the conversation was
|
||||
initiated by a human message, not a CI trigger or scheduled run) — ask:
|
||||
```
|
||||
The reviewer is no longer active. Fixes have been applied:
|
||||
[List of fixes from Step 4]
|
||||
|
||||
Options:
|
||||
(a) Spawn a new reviewer to verify fixes (expensive — full project re-read)
|
||||
(b) Conclude the review — fixes applied, verification is on you
|
||||
```
|
||||
If the operator chooses (a) — spawn a new reviewer with this briefing:
|
||||
```
|
||||
You are reviewing code changes in this repository.
|
||||
|
||||
This is a re-review (Round N). A previous reviewer found issues
|
||||
that have been addressed.
|
||||
|
||||
## Previous findings
|
||||
[Verbatim findings from Round N-1]
|
||||
|
||||
## Fixes applied
|
||||
[List of fixes from Step 4]
|
||||
|
||||
Verify whether fixes resolve the findings. Check for new issues.
|
||||
|
||||
End with VERDICT: APPROVED or VERDICT: REVISE.
|
||||
```
|
||||
Continue from Step 3.
|
||||
If the operator chooses (b) — proceed to Step 6.
|
||||
|
||||
2. **Operator not available** (headless, CI, scheduled run) — proceed
|
||||
to Step 6 with status "fixes applied, not re-verified":
|
||||
```
|
||||
## Team Review — Summary (mode: <mode>)
|
||||
|
||||
**Status:** Fixes applied, re-verification not completed
|
||||
(reviewer became inactive after Round N)
|
||||
|
||||
**Applied fixes:**
|
||||
[List of fixes per finding]
|
||||
|
||||
**Note:** First-round findings were addressed but not re-verified
|
||||
by the reviewer. Manual review of fixes is recommended.
|
||||
```
|
||||
|
||||
### Step 6: Final result
|
||||
|
||||
@@ -215,10 +263,8 @@ Return to **Step 3**.
|
||||
|
||||
### Step 7: Cleanup
|
||||
|
||||
Ask the reviewer teammate to shut down. Then clean up the team.
|
||||
|
||||
If cleanup fails or the user declines — continue without error. Teammates
|
||||
will be cleaned up when the session ends.
|
||||
If the Agent Teams runtime provides a team cleanup mechanism, use it.
|
||||
Failures are non-blocking — teammates are cleaned up when the session ends.
|
||||
|
||||
Do NOT delete plan files that existed before the review.
|
||||
|
||||
@@ -238,11 +284,11 @@ Do NOT delete plan files that existed before the review.
|
||||
- Avoid creating auxiliary files (memory files, state files, logs, temporary
|
||||
markdown) — prefer working within the conversation context
|
||||
- If a fix contradicts user requirements — skip and explain why
|
||||
- The reviewer teammate is stateful — use message, not re-spawn, for
|
||||
subsequent rounds. Re-spawning wastes tokens on re-reading the project
|
||||
tree, re-building context, and re-discovering architecture. Messaging
|
||||
the existing teammate preserves all of that. Save tokens where it
|
||||
doesn't cost quality — spend them where it does.
|
||||
- For re-review rounds, try to continue the existing reviewer teammate
|
||||
first. If the teammate is no longer active, decide by context: ask the
|
||||
operator when available, or conclude without re-verification in headless
|
||||
mode. Re-spawning a new reviewer is expensive (full project re-read) —
|
||||
offer it as an option, not as the default.
|
||||
- The ultimate goal is **higher quality** of plans, code, and other
|
||||
artifacts. Token economy is a means, not an end — never skip a
|
||||
verification step or cut a round short just to save tokens.
|
||||
@@ -255,7 +301,7 @@ Do NOT delete plan files that existed before the review.
|
||||
|------------------------|--------------------------------|--------------------------------|
|
||||
| Reviewer model | External (GPT via Codex CLI) | Claude (same model family) |
|
||||
| Cross-model blind spots| Yes — different model biases | No — same model, different context |
|
||||
| Session persistence | Via `codex exec resume` | Native — teammate stays alive |
|
||||
| Session persistence | Via `codex exec resume` | Try to continue teammate; graceful fallback if inactive |
|
||||
| External dependencies | Codex CLI + OpenAI API key | None — built into Claude Code |
|
||||
| Reviewer capabilities | Read-only sandbox | Read + execute + MCP + web |
|
||||
| Context isolation | Full (different model) | Full (separate context window) |
|
||||
|
||||
Reference in New Issue
Block a user