From 02a98df8c3a07973ee1587cbd755e78ad1be2d1b Mon Sep 17 00:00:00 2001 From: Dmitriy Dementiev Date: Mon, 13 Jul 2026 14:09:25 +0300 Subject: [PATCH] =?UTF-8?q?fix(codex-playbook):=20=D1=83=D1=82=D0=BE=D1=87?= =?UTF-8?q?=D0=BD=D1=91=D0=BD=20=D0=B2=D0=B5=D1=80=D0=B4=D0=B8=D0=BA=D1=82?= =?UTF-8?q?=20=D1=80=D0=B5=D0=B2=D1=8C=D1=8E=20=D0=BF=D0=BB=D0=B0=D0=BD?= =?UTF-8?q?=D0=BE=D0=B2?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Зачем: - ревью высокоуровневых документов могло требовать преждевременных деталей и постоянно блокировать одобрение. - Что: - находки ограничены дефектами на уровне самого документа. - существенные отложенные риски отделены от блокирующих замечаний. - уточнено, что APPROVED допускает открытые вопросы будущей реализации. - Проверка: - quick_validate.py, git diff --check и проверка локальных Markdown-путей. --- .../references/prompt-templates.md | 20 ++++++++++++++++--- .../references/prompts/review-boilerplate.md | 10 ++++++++++ .../references/review-and-triage.md | 8 ++++++++ 3 files changed, 35 insertions(+), 3 deletions(-) diff --git a/agents/.agents/skills/codex-subagent-playbook/references/prompt-templates.md b/agents/.agents/skills/codex-subagent-playbook/references/prompt-templates.md index 7fa8ed4..539da9e 100644 --- a/agents/.agents/skills/codex-subagent-playbook/references/prompt-templates.md +++ b/agents/.agents/skills/codex-subagent-playbook/references/prompt-templates.md @@ -76,9 +76,23 @@ REPORT: absolute unique path `review-focus.md` задаёт один выбранный фокус. Для постановки: ```text -Review the task statement, not an implementation. Check facts against code, -hidden one-line decisions, boundaries, checkable acceptance criteria, and -ways to satisfy the wording without the intended result. +Review the statement or plan at its own level of abstraction, not as an +implementation. Check facts against code, hidden one-line decisions, +boundaries, checkable acceptance criteria, and ways to satisfy the wording +without the intended result. + +A high-level document is not incomplete merely because implementation choices +remain open. Request changes only for a defect the document itself must +resolve: one that changes its goal, boundaries, architectural direction, +acceptance criteria, dependencies, or the ability to decompose work safely. + +When a detail can be decided locally by a downstream owner without changing +those properties, do not make it a finding or prescribe the implementation. +If deferring it carries a relevant risk, record that risk as a non-gating +consideration. + +APPROVED means that no defect at the document's own level requires revision. +It does not mean that all downstream questions have been answered. ``` Для реализации выбери task lens или code lens из договора ревью: diff --git a/agents/.agents/skills/codex-subagent-playbook/references/prompts/review-boilerplate.md b/agents/.agents/skills/codex-subagent-playbook/references/prompts/review-boilerplate.md index f8c2b8f..0bcef87 100644 --- a/agents/.agents/skills/codex-subagent-playbook/references/prompts/review-boilerplate.md +++ b/agents/.agents/skills/codex-subagent-playbook/references/prompts/review-boilerplate.md @@ -15,6 +15,14 @@ Use stable IDs with FINDING PREFIX: `PREFIX-N | BLOCKER|MAJOR|MINOR|NIT | file:line or task section | violated criterion | failure scenario | evidence | minimal verification` +A non-gating consideration has no stable ID, severity, or counter. Use it only +for a material risk from a safely deferred decision, and do not prescribe the +downstream implementation. It does not change the verdict. + +Use CHANGES_REQUESTED only when at least one finding requires revision at the +reviewed artifact's own level. APPROVED means that no such defect remains; it +does not mean that every downstream question has been answered. + If there are no findings, record the reviewed scope and every executed check or tested hypothesis with its outcome. A bare approval is invalid. @@ -25,6 +33,8 @@ Return only: - `VERDICT: APPROVED | CHANGES_REQUESTED` - severity counters; - one line per finding: `ID | severity | area | one-phrase essence`; +- optional one-line material considerations: + `CONSIDERATION | area | one-phrase risk`; - `REPORT: `. Do not repeat the detailed report or reasoning narrative in the final message. diff --git a/agents/.agents/skills/codex-subagent-playbook/references/review-and-triage.md b/agents/.agents/skills/codex-subagent-playbook/references/review-and-triage.md index cd1ab17..12803b8 100644 --- a/agents/.agents/skills/codex-subagent-playbook/references/review-and-triage.md +++ b/agents/.agents/skills/codex-subagent-playbook/references/review-and-triage.md @@ -66,11 +66,19 @@ reviewer -> detailed report file -> triage owner - сценарий сбоя и доказательство; - минимальный способ проверки. +Неблокирующее соображение не получает идентификатор и тяжесть, не входит в +счётчики и не меняет вердикт. Так сохраняй только существенный риск от +отложенного решения, не проектируя реализацию за следующего владельца. +`CHANGES_REQUESTED` означает, что хотя бы одна находка требует исправить +документ на его собственном уровне. `APPROVED` означает отсутствие такого +дефекта, а не отсутствие всех будущих вопросов. + В сообщение координатору верни только: - `VERDICT: APPROVED | CHANGES_REQUESTED`; - счётчики по тяжести; - по одной строке на находку: идентификатор, область, суть и тяжесть; +- по одной строке на существенное неблокирующее соображение, если оно есть; - абсолютный путь к полному отчёту. При отсутствии находок полный файл перечисляет просмотренный объём и